[
https://issues.apache.org/jira/browse/KNOX-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.Andreina updated KNOX-501:
----------------------------
Attachment: KNOX-501.1.patch
Attached a patch which contains a null check on "command" and proper error
message with exit code -1 is added. Included a test case also.
{noformat}
#./knoxcli.sh --cluster clusterName1
ERROR: Invalid Command
Unrecognized option:--cluster
A fatal exception has occurred. Program will exit.
{noformat}
Please review the patch.
> Avoid NPE , in case of passing invalid argument to KnoxCli.
> -----------------------------------------------------------
>
> Key: KNOX-501
> URL: https://issues.apache.org/jira/browse/KNOX-501
> Project: Apache Knox
> Issue Type: Bug
> Reporter: J.Andreina
> Attachments: KNOX-501.1.patch
>
>
> Proper Error message should be displayed , incase of passing invalid argument
> to KnoxCli , instead of throwing NPE.
> {noformat}
> # ./knoxcli.sh --cluster clusterName1
> java.lang.NullPointerException
> at org.apache.hadoop.gateway.util.KnoxCLI.run(KnoxCLI.java:92)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.gateway.util.KnoxCLI.main(KnoxCLI.java:669)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.apache.hadoop.gateway.launcher.Invoker.invokeMainMethod(Invoker.java:70)
> at org.apache.hadoop.gateway.launcher.Invoker.invoke(Invoker.java:39)
> at org.apache.hadoop.gateway.launcher.Command.run(Command.java:101)
> at org.apache.hadoop.gateway.launcher.Launcher.run(Launcher.java:69)
> at org.apache.hadoop.gateway.launcher.Launcher.main(Launcher.java:46)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
