[
https://issues.apache.org/jira/browse/KNOX-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.Andreina updated KNOX-486:
----------------------------
Attachment: KNOX-486.1.patch
Hi Larry ,
bq.I'm not sure about the bootstrapping of this configuration item though - how
do we tell the system where to find the config within the config file?
I too agree with the point that gateway configuration directory (which
contains gateway-site.xml ) cannot be made configurable.
But as Nijel suggested can we make the directory which contains the cluster
topology files as configurable.
For better understanding ,have uploaded a patch with following changes:
{noformat}
1. Gateway topology configuration directory is made configurable
2. Preference for taking the topology directory value is : System Property ->
Environmental variable -> configuration -> default value
3. "gateway.gateway.conf.dir" should be configured to the absolute path which
contains the gateway topology files. (Removed from gateway-site.xml and will
raise a seperate jira to update the document )
4. Added 4 testcases .
{noformat}
Please review the patch and give your feedback.
> Configuration Item gateway.gateway.conf.dir is Obsolete
> -------------------------------------------------------
>
> Key: KNOX-486
> URL: https://issues.apache.org/jira/browse/KNOX-486
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.5.0
> Reporter: Larry McCay
> Attachments: KNOX-486.1.patch
>
>
> Configuration Name in gateway-default.xml is not same as the name used in
> "org.apache.hadoop.gateway.config.impl.GatewayConfigImpl"
> * The deployments directory is no longer found in the conf directory.
> * This config item is not actually referenced anywhere in the server that I
> see with a quick grep
> * Perhaps we can use this to override the default conf dir location itself?
> * or perhaps it should just be removed
> * GatewayConfigImpl class level javadocs are also obsolete and should be
> addressed by this effort as well.
> Incorrect Configuration name in gateway-default.xml
> {noformat}
> <property>
> <name>gateway.gateway.conf.dir</name>
> <value>deployments</value>
> <description>The directory within GATEWAY_HOME that contains gateway
> topology deployments.</description>
> </property>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
