[
https://issues.apache.org/jira/browse/KNOX-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328232#comment-14328232
]
Kevin Minder commented on KNOX-481:
-----------------------------------
Lots of line item feedback but nothing that would prevent a merge and then
subsequent cleanup.
*
gateway-spi/src/main/java/org/apache/hadoop/gateway/dispatch/AbstractGatewayDispatch.java
** Clean up unused imports
* gatway-server/src/main/resources/build.properties
** Un-hardcode bulid.version
*
gateway-server/src/min/java/org/apache/hadoop/gateway/deploy/DeploymentFactory.java
** Resolve import java.util.*
*
gateway-test/src/test/java/org/apache/hadoop/gateway/deploy/DeploymnetFactoryFuncTest.java
** testSimpleTopology()
*** Are there any implications to the change of the role name for webhdfs
dispatch from hdfs to webhdfs?
*** Just want to make sure there wasn't any special code in HdfsDisptach since
the tests indicates GatewayDispatchFilter is now used.
** testDeploymentWithReplayBufferSize
*** Re-comment the dump(doc) to remove the noise from the test output unless
you have a specific reason to need it.
* gateway-spi/src/main/java/org/aapache/hadoop/gateway/config/GatewayConfig.java
** Seems like the gateway-site.xml gatewy.service.dir and GatewayConfig
getGatewayStacksDir() should be aligned. I vote for Services.
* gatway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java
** Follow through with stacks vs services consistency
** failedToLoadServiceDefinition message is vague.
*
gateway-provider-ha/src/main/java/org/pache/hadoop/gateway/ha/provider/HaServletContextListener.java
** What motivated the change of the PROVIDER_ATTRIBUTE_NAME? Just curious.
*
gateway-service-hive/src/main/java/org/pache/hadoop/gateway/hive/Hive/HttpClientDispatch
** Clean up unused imports.
*
gateway-spi/src/main/java/org/apache/hadoop/gateway/dispatch/HttpClientDispatch.java
** Clean up unused imports.
** Clean up unthrown exception from executeKerberosDispatch
* /gateway-release/pom.xml
** A comment about what the maven-dependency-plugin is doing would be helpful
for future generations.
* gateway-util-config-injector/pom.xml
** Move the version number of commons-beanutils up to the root pom.xml
*
gatewaay-server/src/main/java/org/apache/hadoop/gateway/deploy/impl/ServiceDefinitioDeploymentContributor.java
** addDispatchFilterForClass
*** The special case for Hive being applied to all dispatches isn't great.
*
gateway-server/src/main/java/org/apche/hadoop/gateway/topology/builder/property/interpreter/ServicePropertyInterpreter.java
** Does the TODO:sumit need to be resolved before commit?
* gateway-spi/src/amin/java/org/apache/hadoop/gateway/topology/Topology.java
** Don't like import *
** Is there ever a case where you ned to find a service by just role and name
and not version?
*
gateway-spi/src/test/java/org/apache/hadoop/gateway/topology/xml/TopologyRulesModuleTests.java
** Same question as above since you don't test for this.
*
gateway-service-webhdfs/src/main/java/org/apache/hadoop/gateway/hdfs/dispatch/WebHdfsHaHttpClientDispatch.java
** Did you have to do something special to get @Configure setHaProvider to
work? I thought the config injector stuff only worked with things that could
be coerced to/from strings.
> Support configuration driven REST API integration (aka Stacks)
> --------------------------------------------------------------
>
> Key: KNOX-481
> URL: https://issues.apache.org/jira/browse/KNOX-481
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 0.6.0
> Reporter: Sumit Gupta
> Assignee: Sumit Gupta
> Fix For: 0.6.0
>
>
> The gateway server has a framework that allows for plugging in new
> 'services'. The framework requires code to be written for every new service
> that is added in. We need a way to make adding new services easy and make it
> possible to add a new service without writing any code (using configuration
> instead) while leaving open the flexibility of being able to write code if
> necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
