[
https://issues.apache.org/jira/browse/KNOX-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574791#comment-14574791
]
Kevin Minder commented on KNOX-554:
-----------------------------------
Patch review feedback
* No CHANGES update
*
gateway-service-admin/src/main/java/org/apache/hadoop/gateway/service/admin/TopologiesResource.java
** buildURI & buildHref
*** These would benefit from some pure unit testing. This would really help
document what these methods do.
* gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServer.java
** internalDeploy
*** Ideally there should be a constant somewhere for
"org.apache.knox.gateway.config".
*
gateway-provider-jersey/src/main/java/org/apache/hadoop/gateway/jersey/JerseyServiceDeploymentContributorBase.java
** contributeService
*** I believe in ServiceDescriptorDeploymentContributor the XForwrdedFilter is
added first in the chain. We should be consistent here.
*
gateway-test/src/test/java/org/apache/hadoop/gateway/GatewayAdminTopologyFuncTest.java
** testXForwarddHeaders
*** This test doesn't seem to use the X-Forward-* headers to change the
returned URLs to something other than they would be without them. How does
this prove that it is working?
** testGatewayPathChange
*** The restarting of the gateway back to the default config should happen in a
finally block to ensure other tests aren't affected if this one fails.
> Cannot access topologies through admin API if gateway.path is modified
> ----------------------------------------------------------------------
>
> Key: KNOX-554
> URL: https://issues.apache.org/jira/browse/KNOX-554
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Zachary Blanco
> Assignee: Zachary Blanco
> Attachments: KNOX-554-1.patch, KNOX-554-2.patch
>
>
> If a user edits the gateway.path property to any value other than "gateway"
> in gateway-site.xml, the calls to the admin API for topologies fail.
> Specifically any GET request to:
> https://{gateway-host}:{gateway-port}/{gateway.path}/admin/api/v1/topologies
> OR
> https://{gateway-host}:{gateway-port}/{gateway.path}/admin/api/v1/topologies/{topology-id}
> Will fail if the gateway.path is not set to "gateway"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
