[
https://issues.apache.org/jira/browse/KNOX-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579411#comment-14579411
]
Kevin Minder edited comment on KNOX-554 at 6/9/15 7:03 PM:
-----------------------------------------------------------
Feedback on KNOX-554-3.patch
* GatewayAdminTopologyFuncTest
** testXForwardedHeaders
*** I still don't see and tests here where the X-Forwarded-* headers are used
to change the expected result. What about this test tells you that the
X-Forwarded-* headers are actually having an affect?
* pom.xml
** Please don't use version numbers for dependencies in child pom.xml files.
Doing this can lead to conflicting version requirements between modules.
* TopologyResource
** You didn't need to make buildURI and buildHref public to test them. Package
private would have been better. See:
https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html if you
aren't clear on what package private means.
was (Author: kminder):
Feedback on KNOX-554-3.patch
* GatewayAdminTopologyFuncTest
** testXForwardedHeaders
*** I still don't see and tests here where the X-Forwarded-* headers are used
to change. What about this test tells you that the X-Forwarded-* headers are
actually having an affect?
* pom.xml
** Please don't use version numbers for dependencies in child pom.xml files.
Doing this can lead to conflicting version requirements between modules.
* TopologyResource
** You didn't need to make buildURI and buildHref public to test them. Package
private would have been better. See:
https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html if you
aren't clear on what package private means.
> Cannot access topologies through admin API if gateway.path is modified
> ----------------------------------------------------------------------
>
> Key: KNOX-554
> URL: https://issues.apache.org/jira/browse/KNOX-554
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Zachary Blanco
> Assignee: Zachary Blanco
> Attachments: KNOX-554-1.patch, KNOX-554-2.patch, KNOX-554-3.patch
>
>
> If a user edits the gateway.path property to any value other than "gateway"
> in gateway-site.xml, the calls to the admin API for topologies fail.
> Specifically any GET request to:
> https://{gateway-host}:{gateway-port}/{gateway.path}/admin/api/v1/topologies
> OR
> https://{gateway-host}:{gateway-port}/{gateway.path}/admin/api/v1/topologies/{topology-id}
> Will fail if the gateway.path is not set to "gateway"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
