+1 :) On Wed, Aug 12, 2015 at 12:16 PM, Sumit Gupta <[email protected]> wrote:
> Agreed on XForwardHeaders related tests. I can take those on and I will > file a JIRA to track it. > > Thanks Zac for taking the CLIServiceTest failure. > > Sumit. > > On 8/12/15, 12:11 PM, "larry mccay" <[email protected]> wrote: > > >All - > > > >I see that KNOX-584 was filed by Zac to address this but I wanted to make > >sure that everyone is aware that we have some instability in the jenkins > >builds. > > > >See: https://builds.apache.org/job/Knox-master-verify/701/ > > > >We have 3 failures there: > > > >1. in CLIServiceTest - covered by KNOX-584: > >Error Message > > > >Expected: a string containing "nodename nor servname provided" > > but: was "Username and/or password not supplied. Expect HTTP 401 > >Unauthorized responses. > >bad-host: Name or service not known > >" > > > >Stacktrace > > > >java.lang.AssertionError: > >Expected: a string containing "nodename nor servname provided" > > but: was "Username and/or password not supplied. Expect HTTP 401 > >Unauthorized responses. > >bad-host: Name or service not known > >" > > at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) > > at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) > > at > >org.apache.hadoop.gateway.GatewayBasicFuncTest.testCLIServiceTest(GatewayB > >asicFuncTest.java:3560) > > > > > >2. Two in the XForwardHeaders related tests - both seemingly related > >to 127.0.0.1 vs localhost expectations: > > > > > >Error Message > > > >2 expectations failed. > >Expected status code <200> doesn't match actual status code <500>. > > > >Expected content-type "application/json" doesn't match actual > >content-type "text/html;charset=ISO-8859-1". > > > >Stacktrace > > > >java.lang.AssertionError: 2 expectations failed. > >Expected status code <200> doesn't match actual status code <500>. > > > >Expected content-type "application/json" doesn't match actual > >content-type "text/html;charset=ISO-8859-1". > > > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > > at > >sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAcc > >essorImpl.java:57) > > at > >sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstr > >uctorAccessorImpl.java:45) > > at java.lang.reflect.Constructor.newInstance(Constructor.java:526) > > at > >org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor. > >java:77) > > at > >org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(Cache > >dConstructor.java:71) > > at > >org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwr > >ap.callConstructor(ConstructorSite.java:81) > > at > >org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor( > >CallSiteArray.java:54) > > at > >org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(Abst > >ractCallSite.java:182) > > at > >org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(Abst > >ractCallSite.java:190) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl$HamcrestAssertio > >nClosure.validate(ResponseSpecificationImpl.groovy:399) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl$HamcrestAssertio > >nClosure$validate.call(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.invokeFilterChain > >(RequestSpecificationImpl.groovy:759) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl$invokeFilterChain > >.callCurrent(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.applyPathParamsAn > >dSendRequest(RequestSpecificationImpl.groovy:1142) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.this$2$applyPathP > >aramsAndSendRequest(RequestSpecificationImpl.groovy) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl$this$2$applyPathP > >aramsAndSendRequest.callCurrent(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.get(RequestSpecif > >icationImpl.groovy:131) > > at > com.jayway.restassured.specification.RequestSender$get.call(Unknown > >Source) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl.get(ResponseSpec > >ificationImpl.groovy:226) > > at > >org.apache.hadoop.gateway.GatewayBasicFuncTest.testXForwardHeadersPopulate > >(GatewayBasicFuncTest.java:3265) > > > >Standard Error > > > >java.lang.AssertionError: Request GET > >http://127.0.0.1:34604/api/v1/topology/WordCount-1-1424792039 does not > >have the expected value for header X-Forwarded-Server > >Expected: is "localhost" > > but: was "127.0.0.1" > > at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) > > at > >org.apache.hadoop.test.mock.MockRequestMatcher.match(MockRequestMatcher.ja > >va:217) > > at > org.apache.hadoop.test.mock.MockServlet.service(MockServlet.java:46) > > at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) > > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684) > > at > >org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501) > > at > >org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.ja > >va:229) > > at > >org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.ja > >va:1086) > > at > >org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428) > > at > >org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.jav > >a:193) > > at > >org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.jav > >a:1020) > > at > >org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:1 > >35) > > at > >org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java > >:116) > > at org.eclipse.jetty.server.Server.handle(Server.java:370) > > at > >org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttp > >Connection.java:494) > > at > >org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHtt > >pConnection.java:971) > > at > >org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerCompl > >ete(AbstractHttpConnection.java:1033) > > at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644) > > at > org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235) > > at > >org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.ja > >va:82) > > at > >org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoin > >t.java:667) > > at > >org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint > >.java:52) > > at > >org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.jav > >a:608) > > at > >org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java > >:543) > > at java.lang.Thread.run(Thread.java:724) > > > > > > > >and > > > > > > > >org.apache.hadoop.gateway.GatewayBasicFuncTest.testXForwardHeadersRewrite > >Failing for the past 1 build (Since [image: Unstable]#701 > >< > https://builds.apache.org/job/Knox-master-verify/org.apache.knox$gateway- > >test/701/> > >) > >Took 20 ms. > >< > https://builds.apache.org/job/Knox-master-verify/org.apache.knox$gateway- > >test/701/testReport/junit/org.apache.hadoop.gateway/GatewayBasicFuncTest/t > >estXForwardHeadersRewrite/history> > >Error Message > > > >2 expectations failed. > >Expected status code <200> doesn't match actual status code <500>. > > > >Expected content-type "application/json" doesn't match actual > >content-type "text/html;charset=ISO-8859-1". > > > >Stacktrace > > > >java.lang.AssertionError: 2 expectations failed. > >Expected status code <200> doesn't match actual status code <500>. > > > >Expected content-type "application/json" doesn't match actual > >content-type "text/html;charset=ISO-8859-1". > > > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > > at > >sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAcc > >essorImpl.java:57) > > at > >sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstr > >uctorAccessorImpl.java:45) > > at java.lang.reflect.Constructor.newInstance(Constructor.java:526) > > at > >org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor. > >java:77) > > at > >org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(Cache > >dConstructor.java:71) > > at > >org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwr > >ap.callConstructor(ConstructorSite.java:81) > > at > >org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(Abst > >ractCallSite.java:190) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl$HamcrestAssertio > >nClosure.validate(ResponseSpecificationImpl.groovy:399) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl$HamcrestAssertio > >nClosure$validate.call(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.invokeFilterChain > >(RequestSpecificationImpl.groovy:759) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl$invokeFilterChain > >.callCurrent(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.applyPathParamsAn > >dSendRequest(RequestSpecificationImpl.groovy:1142) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.this$2$applyPathP > >aramsAndSendRequest(RequestSpecificationImpl.groovy) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl$this$2$applyPathP > >aramsAndSendRequest.callCurrent(Unknown > >Source) > > at > >com.jayway.restassured.internal.RequestSpecificationImpl.get(RequestSpecif > >icationImpl.groovy:131) > > at > com.jayway.restassured.specification.RequestSender$get.call(Unknown > >Source) > > at > >com.jayway.restassured.internal.ResponseSpecificationImpl.get(ResponseSpec > >ificationImpl.groovy:226) > > at > >org.apache.hadoop.gateway.GatewayBasicFuncTest.testXForwardHeadersRewrite( > >GatewayBasicFuncTest.java:3317) > > > >Standard Error > > > >java.lang.AssertionError: Request GET > >http://127.0.0.1:34604/api/v1/topology/WordCount-1-1424792039 does not > >have the expected value for header X-Forwarded-Server > >Expected: is "localhost" > > but: was "127.0.0.1" > > at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) > > at > >org.apache.hadoop.test.mock.MockRequestMatcher.match(MockRequestMatcher.ja > >va:217) > > at > org.apache.hadoop.test.mock.MockServlet.service(MockServlet.java:46) > > at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) > > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684) > > at > >org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501) > > at > >org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.ja > >va:229) > > at > >org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.ja > >va:1086) > > at > >org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428) > > at > >org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.jav > >a:193) > > at > >org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.jav > >a:1020) > > at > >org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:1 > >35) > > at > >org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java > >:116) > > at org.eclipse.jetty.server.Server.handle(Server.java:370) > > at > >org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttp > >Connection.java:494) > > at > >org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHtt > >pConnection.java:971) > > at > >org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerCompl > >ete(AbstractHttpConnection.java:1033) > > at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644) > > at > org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235) > > at > >org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.ja > >va:82) > > at > >org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoin > >t.java:667) > > at > >org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint > >.java:52) > > at > >org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.jav > >a:608) > > at > >org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java > >:543) > > at java.lang.Thread.run(Thread.java:724) > > > > > >We should probably change the XForwardHeaders related tests to accommodate > >either 127.0.0.1 and localhost as expected in order to avoid this. > > > >Thoughts? > > > >--larry > >
