[
https://issues.apache.org/jira/browse/KNOX-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904610#comment-14904610
]
ASF subversion and git services commented on KNOX-447:
------------------------------------------------------
Commit cb5465755a81d9826a3160af3b626f5ef9b39514 in knox's branch
refs/heads/master from [~kevin.minder]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=cb54657 ]
KNOX-447: Incorrect parsing and expansion of valueless query params
> Incorrect parsing and expansion of valueless query params
> ----------------------------------------------------------
>
> Key: KNOX-447
> URL: https://issues.apache.org/jira/browse/KNOX-447
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.4.0
> Reporter: Kevin Minder
> Assignee: Kevin Minder
> Priority: Critical
> Fix For: 0.7.0
>
>
> Parser.parse produces a result with Query object that contains an array of
> one null value which is incorrect.
> The test below failed with this assertion failure
> {code}
> Assertion failure:
> Expected:
> equalToIgnoringCase("https://webhcatTestHost.com:50111/templeton/v1/?version/hive";)
> but: was
> https://webhcatTestHost.com:50111/templeton/v1/?version/hive=null
> {code}
> {code:java}
> @Test
> public void testValuelessQueryParamParsingAndExpansion() throws Exception {
> URI inputUri, outputUri;
> Matcher<Void> matcher;
> Matcher<Void>.Match match;
> Template input, pattern, template;
> Evaluator evaluator;
> inputUri = new URI(
> "https://knoxHost:8443/gateway/knoxTopo/templeton/v1/?version/hive"; );
> input = Parser.parse( inputUri.toString() );
> pattern = Parser.parse( "*://*:*/**/templeton/v1/?{**}" );
> template = Parser.parse( "{$serviceUrl[WEBHCAT]}/v1/?{**}" );
> matcher = new Matcher<Void>();
> matcher.add( pattern, null );
> match = matcher.match( input );
> evaluator = new Evaluator() {
> @Override
> public List<String> evaluate( String function, List<String> parameters
> ) {
> return Arrays.asList( "https://webhcatTestHost.com:50111/templeton"; );
> }
> };
> outputUri = Expander.expand( template, match.getParams(), evaluator );
> assertThat(
> outputUri.toString(),
> equalToIgnoringCase(
> "https://webhcatTestHost.com:50111/templeton/v1/?version/hive"; ) );
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
