[
https://issues.apache.org/jira/browse/KNOX-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067707#comment-15067707
]
Jérôme Leleu commented on KNOX-641:
-----------------------------------
I just uploaded a second patch. All comments have been accounted:
1) `@author` has been removed
2) The `pac4j.callbackUrl` is the parameter of the callback url
3) The `getDomainName` method has been extracted into the `Urls` helper and is
used by the `KnoxSessionStore`: notice that when the computed domain is null,
the default domain is the server name
4) The `Pac4jProviderTest` simulates a full authentication process, checking
cookies, HTTP status, redirections...
5) The pac4j user profile is cleaned at the end of the login process (in favor
of the KnoxSSO session and the identity provider session **remains**)
6) The `testBasicAuth` facility has been kept.
Given your recommendation, I don't think it's necessary to open a new debatte
on the dev mailing list.
Moving to the documentation.
> Support CAS / OAuth / OpenID C / SAML protocols using pac4j
> -----------------------------------------------------------
>
> Key: KNOX-641
> URL: https://issues.apache.org/jira/browse/KNOX-641
> Project: Apache Knox
> Issue Type: New Feature
> Reporter: Jérôme Leleu
> Assignee: Jérôme Leleu
> Fix For: 0.8.0
>
> Attachments: KNOX-641.patch, knox641.patch2
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
