[ 
https://issues.apache.org/jira/browse/KNOX-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094139#comment-15094139
 ] 

Jérôme Leleu commented on KNOX-641:
-----------------------------------

Indeed, all pac4j profiles (CasProfile, SAML2Profile, ...) have an identifier 
and various attributes depending on the identity providers and its 
configuration.

I'm not sure to understand what are the use cases for which you want to have 
different usernames, but we could easily take an attribute of the user profile 
instead of the identifier to choose the username of the principal (in the 
Pac4jIdentityAdapter) and this chosen-username-from-user-attribute could be 
optional.

I also successfully tested SAML support. The only issue is the missing velocity 
dependency in the pac4j module. See: 
https://github.com/leleuj/knox/commit/d5e5c6627a1907bec13c7a618725ee20b1d683d5

I'm completely open to improvments (like the one suggested above), but I think 
it would be better to merge the current patch with the pac4j version / velocity 
updates and then start working on improvments.


> Support CAS / OAuth / OpenID C / SAML protocols using pac4j
> -----------------------------------------------------------
>
>                 Key: KNOX-641
>                 URL: https://issues.apache.org/jira/browse/KNOX-641
>             Project: Apache Knox
>          Issue Type: New Feature
>            Reporter: Jérôme Leleu
>            Assignee: Jérôme Leleu
>             Fix For: 0.8.0
>
>         Attachments: KNOX-641.patch, knox641.patch2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to