I agree with Sumit. As long as none of the scripting that is used by Ambari is explicitly referencing the jar and no classes/packages are renamed out from under a script then rolling upgrades and Ambari support for various versions should remain intact.
I don't see any reason for this to affect 0.8.0 planning and I see it as a bug fix that should be included in 0.8.0. If anyone disagrees then we can discuss branching for 0.8.0 now and committing this to master only. +1 on the patch as it stands. On Thu, Jan 14, 2016 at 10:00 AM, Sumit Gupta <[email protected]> wrote: > The patch looks like a simple (i.e. harmless) refactor/rename to me. I > don¹t see any upgrade issues unless people are writing their own > launchers, which doesn¹t make sense. In any case no one should be using > the test/demo ldap in production. > > +1 > > Sumit. > > On 1/13/16, 3:16 PM, "Kevin Minder" <[email protected]> wrote: > > >Hey Everyone, > > > >I¹m thinking about pushing this to master. I¹ve attached a format-patch > >to the jira for review. > >https://issues.apache.org/jira/browse/KNOX-647 > > > https://issues.apache.org/jira/secure/attachment/12782120/0001-KNOX-647-Re > >name-LDAP-artifacts-from-test-to-demo.patch > > > >The basic questions are: > > > > 1. How would pushing this to master this affect the 0.8.0 planning? > > 2. Am I missing something that would be a likely upgrade issue? > > > >BTW. The crux of the change from an installed product is that this > > <GATEWAY-HOME>/lib/gateway-test-ldap-0.8.0.jar > >would be now be this > > <GATEWAY-HOME>/lib/gateway-demo-ldap-0.8.0.jar > > > >Kevin. > >
