[
https://issues.apache.org/jira/browse/KNOX-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283573#comment-15283573
]
Hadoop QA commented on KNOX-712:
--------------------------------
Testing JIRA KNOX-712
Patch
[KNOX-712-002.patch|https://issues.apache.org/jira/secure/attachment/12804026/KNOX-712-002.patch]
downloaded at Sat May 14 14:22:16 UTC 2016
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
. {color:red}WARNING{color}: the current HEAD has 76 javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
. {color:red}WARNING: the current HEAD has Findbugs warning(s), they should
be addressed ASAP{color}
{color:green}+1 TESTS{color}
. Tests run: 667
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/Knox-master-patch-verify/50/
> submitPig does not allow multiple argument via arg()
> ----------------------------------------------------
>
> Key: KNOX-712
> URL: https://issues.apache.org/jira/browse/KNOX-712
> Project: Apache Knox
> Issue Type: Bug
> Components: ClientDSL
> Affects Versions: 0.7.0
> Reporter: Pierre Regazzoni
> Assignee: Pierre Regazzoni
> Fix For: 0.9.1
>
> Attachments: KNOX-712-002.patch, KNOX-712.patch
>
>
> Seems like I can't pass multiple argument via knox shell as follow:
> {noformat}
> jobId = Job.submitPig(session) \
> .arg( "-p" ) \
> .arg( "someparam=somevalue" ) \
> .arg( "-v" ) \
> ...
> {noformat}
> Looking at code looks like [Pig
> code|https://github.com/apache/knox/blob/master/gateway-shell/src/main/java/org/apache/hadoop/gateway/shell/job/Pig.java]
> can only take one arg.
> Would expect code to be as follow:
> {noformat}
> public Request arg( String arg ) {
> addParam( params, "arg", value );
> return this;
> }
> {noformat}
> {noformat}
> protected Callable<Response> callable() {
> return new Callable<Response>() {
> @Override
> public Response call() throws Exception {
> URIBuilder uri = uri( Job.SERVICE_PATH, "/pig" );
> List<NameValuePair> params = new ArrayList<NameValuePair>();
> addParam( params, "group", group );
> addParam( params, "file", file );
> addParam( params, "statusdir", statusDir );
> UrlEncodedFormEntity form = new UrlEncodedFormEntity( params );
> HttpPost request = new HttpPost( uri.build() );
> request.setEntity( form );
> return new Response( execute( request ) );
> }
> };
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
