Marco Battaglia created KNOX-720:
------------------------------------

             Summary: Sockets remain in CLOSE_WAIT using 
org.apache.hadoop.gateway.shell.Hadoop
                 Key: KNOX-720
                 URL: https://issues.apache.org/jira/browse/KNOX-720
             Project: Apache Knox
          Issue Type: Bug
          Components: ClientDSL
    Affects Versions: 0.7.0
            Reporter: Marco Battaglia


The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox 
doesn't close opened socket.
The "shutdown" method of org...shell.Hadoop doesn't call client.close() and 
this produces  too much permanent CLOSE_WAIT sockest.

Suggestion:


    public void shutdown() throws InterruptedException {
 -    
 +    closeClient();
    }
  
    public boolean shutdown( long timeout, TimeUnit unit ) throws 
InterruptedException {
-      executor.shutdown();
 +    closeClient();
      return executor.awaitTermination( timeout, unit );
    }
 +  
 +  private void closeClient(){
+      executor.shutdownNow();
 +    if(client!=null){
 +      client.close();
 +    }
 +  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to