[ 
https://issues.apache.org/jira/browse/KNOX-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401143#comment-15401143
 ] 

Larry McCay commented on KNOX-644:
----------------------------------

Couple quick review comments on the patches:

* We need to add some unit tests for each feature/improvement
* Both patches seem to be adding the additional groups to user.ldif - if this 
is the same set and we don't need additional for paging then we should just 
have the paging one assume that the the other one was already applied

> Limit/page results of LDAP group membership search 
> ---------------------------------------------------
>
>                 Key: KNOX-644
>                 URL: https://issues.apache.org/jira/browse/KNOX-644
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.6.0
>            Reporter: Kevin Minder
>            Priority: Critical
>             Fix For: 0.10.0
>
>         Attachments: KNOX-644.patch, ad_setup.ps1, create_groups_ldif.py, 
> paging.patch
>
>
> Some users are finding that they have >1000 groups that would be returned 
> given how Knox currently implements group lookup. ActiveDirectory currently 
> limits search results to 1000 items and this causes failures that require 
> workarounds at the client side.  Ideally Knox's LDAP group search 
> implementation would either limit/filter the results or page the result set 
> that are unavoidably large.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to