Awesome ! Thanks Sumit.
> On Oct 24, 2016, at 12:49 PM, Sumit Gupta <[email protected]> wrote: > > Thanks Sandeep. I think that is a valid suggestion and something I should > be able to throw in for this iteration as well. > > Thanks again for the feedback! > > Sumit > > >> On 10/24/16, 1:09 PM, "Sandeep More" <[email protected]> wrote: >> >> Hello Sumit, >> >> The KIP looks great ! apologies for not jumping in earlier :( >> I have a suggestion to add "request failure" metrics, perhaps in the later >> iterations. >> >> KNOX-643 <https://issues.apache.org/jira/browse/KNOX-643> already covers >> the requirement for unsuccessful and failed logins, it would be good to >> have a failure count for request/response so one can keep track of >> occasional or unexpected failures once a while. >> >> Thanks ! >> Sandeep >> >>> On Mon, Oct 24, 2016 at 11:23 AM, sumit gupta <[email protected]> wrote: >>> >>> All, >>> >>> I would like to solicit comments and feedback on KIP-2 and work done >>> in the patch for KNOX-643. The topic of adding metrics to the gateway >>> has been discussed before and resulted in KNOX-643. At this point I am >>> looking for an initial implementation that satisfies some of the main >>> requirements and allows us to get to the rest of the requirements in >>> an iterative process. This is essentially what is described in KIP-2. >>> >>> https://cwiki.apache.org/confluence/display/KNOX/KIP-2+Metrics >>> >>> While some more content has to be added to the document (especially >>> around graphite/grafana reporting), the main ideas should come across >>> and hopefully are enough to start the discussion and help shape the >>> initial contribution that I would like to get into the codebase by the >>> end of this week (unless there are significant changes needed based on >>> feedback). >>> >>> Thanks. >>> Sumit >>> >
