[
https://issues.apache.org/jira/browse/KNOX-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606987#comment-15606987
]
Sandeep More commented on KNOX-752:
-----------------------------------
Patch Comments:
Following are the comments for the patch "KNOX-752.002.patch"
as a result of an offline discussion with [~lmccay] and [~sumit.gupta]
gateway-site.xml
1) Remove all the newly added <property> elements except the property
"gateway.websocket.feature.enabled"
2) Change "gateway.websocket.feature.enabled" to be false by default.
3) Get rid of the white space.
Next iteration:
1) Move config params during creating connections (topology based).
GatewayServer.java
1) Undo the reformatting for the code that is not touched.
2) Get rid of the white space.
GatewayConfigImpl.java
1) Change "gateway.websocket.feature.enabled" to be false by default.
2) Get rid of the white space.
POM.xml
1) White space
GatewayWebsocketHandler.java:
1) Cleanup unused code - urlRewriteRules
2) Derive topology from request path.
3) It was suggested to create a ServiceDefinitionRegistry - probably a
separate JIRA, to optimize the for loops, mapping between routes and services.
4) File a JIRA for the api ServiceRegistry.lookupServiceURL() - accepts
only uppercase string, should be case insensitive.
ProxyWebSocketAdapter.java:
1) Fix the fixmes : throw unsupportedmethod exception for methods not
yet implemented. Gracefully close connection.
2) Fix the FIXME LOG statements.
> Knox Websocket support
> -----------------------
>
> Key: KNOX-752
> URL: https://issues.apache.org/jira/browse/KNOX-752
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 0.10.0
> Reporter: Sandeep More
> Assignee: Sandeep More
> Labels: features
> Fix For: 0.10.0
>
> Attachments: KNOX-752.001.patch, KNOX-752.002.patch
>
>
> Provide support to proxy websocket connections, this will help UIs such as
> Zeppelin which use Websockets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
