[ 
https://issues.apache.org/jira/browse/KNOX-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625477#comment-15625477
 ] 

John McParland edited comment on KNOX-757 at 11/1/16 1:49 PM:
--------------------------------------------------------------

[~sumit.gupta] Is your intention is to include by default in some of the log4j 
properties often used as part of Shiro?

That is, add the following properties, which appear in this test log4j 
properties for Shiro:
https://github.com/apache/shiro/blob/master/core/src/test/resources/log4j.properties

{code}
# Spring logging level is WARN
log4j.logger.org.springframework=WARN

# General Apache libraries is WARN
log4j.logger.org.apache=WARN

log4j.logger.net.sf.ehcache=WARN

log4j.logger.org.apache.shiro=TRACE
log4j.logger.org.apache.shiro.util.ThreadContext=WARN
{code}

Only {code}log4j.logger.org.apache.shiro=DEBUG{code} currently appears in the 
default log4j properties for Knox: 
https://github.com/apache/knox/blob/master/gateway-release/home/conf/gateway-log4j.properties

My draft acceptance criteria is

 * Allow an Knox installer/developer to quickly switch on Apache Shiro-related 
logging by commenting-in the appropriate log4j properties
 * By default, leave Apache Shiro related logging commented out
 * Include the following loggers (shiro related libraries/frameworks)
    ** org.springframework
    ** net.sf.ehcache
    ** org.apache.shiro
    ** org.apache.shiro.util.ThreadContext

I'm keen to take this on as an introduction to Knox development.



was (Author: mcparlandjcgi):
[~sumit.gupta] Is your intention is to include by default in some of the log4j 
properties often used as part of Shiro?

That is, add the following properties, which appear in 
https://github.com/apache/shiro/blob/master/core/src/test/resources/log4j.properties

{code}
# Spring logging level is WARN
log4j.logger.org.springframework=WARN

# General Apache libraries is WARN
log4j.logger.org.apache=WARN

log4j.logger.net.sf.ehcache=WARN

log4j.logger.org.apache.shiro=TRACE
log4j.logger.org.apache.shiro.util.ThreadContext=WARN
{code}

Only {code}log4j.logger.org.apache.shiro=DEBUG{code} appears in 
https://github.com/apache/knox/blob/master/gateway-release/home/conf/gateway-log4j.properties

My draft acceptance criteria is

 * Allow an Knox installer/developer to quickly switch on Apache Shiro-related 
logging by commenting-in the appropriate log4j properties
 * By default, leave Apache Shiro related logging commented out
 * Include the following loggers (shiro related libraries/frameworks)
    ** org.springframework
    ** net.sf.ehcache
    ** org.apache.shiro
    ** org.apache.shiro.util.ThreadContext

I'm keen to take this on as an introduction to Knox development.


> Add log4j properties for shiro related logs to the gateway log4j file
> ---------------------------------------------------------------------
>
>                 Key: KNOX-757
>                 URL: https://issues.apache.org/jira/browse/KNOX-757
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Sumit Gupta
>
> Properties for controlling logging for shiro functionality should be made 
> easier to switch on/off in the gateway log4j file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to