[ 
https://issues.apache.org/jira/browse/KNOX-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636387#comment-15636387
 ] 

Jeffrey E  Rodriguez commented on KNOX-771:
-------------------------------------------

Hi Sandeep quick question. Do you mean ServiceDefinition.getName() ?? So is 
this about making service name case insensitive??
 "Route" doesn't have name. "Route" only have rewrites, policies and dispatch.
An example:
<service role="FOO" name="foo" version="1.0.0">
    <policies> 
        <policy role="webappsec"/>
        <policy role="authentication"/> 
        <policy role="rewrite"/>
        <policy role="identity-assertion"/>
        <policy role="authorization"/>
    </policies>
    <routes>
        <route path="/foo/?**">
            <rewrite apply="FOO/foo/inbound" to="request.url"/>
            <policies>
                <policy role="webappsec"/>
                <policy role="federation"/>
                <policy role="identity-assertion"/>
                <policy role="authorization"/>
                <policy role="rewrite"/>
            </policies>
            <dispatch contributor-name="http-client" />
        </route>
    </routes>


> ServiceRegistry.lookupServiceURL() args should be case insensitive. 
> --------------------------------------------------------------------
>
>                 Key: KNOX-771
>                 URL: https://issues.apache.org/jira/browse/KNOX-771
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Sandeep More
>
> The API ServiceRegistry.lookupServiceURL(String clusterName, String 
> serviceName) in ServiceRegistry requires  'serviceName' to be in uppercase 
> which is not always the case for e.g. 
> ServiceDefinition.getRoutes().get(0).getName() can returns name in lowercase.
> We need them to be case insensitive and document it in the interface 
> definition. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to