[ 
https://issues.apache.org/jira/browse/KNOX-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15740200#comment-15740200
 ] 

Vincent Devillers commented on KNOX-805:
----------------------------------------

Sure, that's a good idea! Maybe instead of passing an httpclient in 
Hadoop.login(url, user,password), we could pass a HttpClientConfiguration 
holding some properties like:
- timeouts (read, connect...)
- connection pool (sizing, thread factory name...)
- socket attributes
- custom headers

The method Hadoop.login(url, user,password) will call Hadoop.login(url, 
user,password, httpclientconfiguration) using a default httpclientconfiguration.

What do you think?

> Allow defining a custom HttpClient when creating a new session
> --------------------------------------------------------------
>
>                 Key: KNOX-805
>                 URL: https://issues.apache.org/jira/browse/KNOX-805
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: ClientDSL
>            Reporter: Vincent Devillers
>            Assignee: Vincent Devillers
>
> When creating a new session, I think it should be possible to specify a 
> custom CloseableHttpClient in parameter of the static method 
> Hadoop.login(url, user,password). This will allow to prepare a well defined 
> CloaseableHttpClient if you want to add headers, limit the length of the 
> message send, define specific strategy on dns resolution or hostname 
> verification, size the connection pool…



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to