[
https://issues.apache.org/jira/browse/KNOX-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849885#comment-15849885
]
Larry McCay commented on KNOX-867:
----------------------------------
[~coheigea] - thank you for this clean up effort.
As always very helpful.
It looks good after a quick review.
I will give it a spin and hopefully get it in today.
> Fix FindBugs "bad practice" issues
> ----------------------------------
>
> Key: KNOX-867
> URL: https://issues.apache.org/jira/browse/KNOX-867
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Fix For: 0.12.0
>
> Attachments: 0001-KNOX-867-Fix-FindBugs-bad-practice-issues.patch
>
>
> Similar to KNOX-792, this task is to fix (some of) the "bad practice" issues
> identified by FindBugs in the Knox code base. The issues fixed in the
> attached patch are:
> a) Not checking the return value of File.mkdirs()
> b) Not implementing Serializable when implementing Comparator
> c) A few performance regressions where keySet is used instead of entrySet
> d) Using platform specific "\n" instead of "%n" in String.format
> e) Not overriding hashCode when overriding equals
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
