[ 
https://issues.apache.org/jira/browse/KNOX-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860201#comment-15860201
 ] 

Sandeep More commented on KNOX-870:
-----------------------------------

Hello [~kamrul] the patch looks good, few things though, 
1. Can you move the section you added *Supporting a Custom Validator* to Dev 
Guide instead of User Guide since this is an extension to Knox.
2. Link it back to the User Guide so one knows about Custom Validators.

Also, I noticed that the current book is 0.11, it should be 0.12. I will create 
a new book for 0.12 so you can create a patch for it there (currently you have 
it against 0.11). I will let you know once I am done so you can create a patch. 

> Documentation: how to support custom pre-auth validator 
> --------------------------------------------------------
>
>                 Key: KNOX-870
>                 URL: https://issues.apache.org/jira/browse/KNOX-870
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Mohammad Kamrul Islam
>             Fix For: 0.12.0
>
>         Attachments: KNOX-870.1.patch
>
>
> KNOX-861 supports pluggable preauth validator.
> This task is to add proper documentation about how to add custom validator(s).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to