[
https://issues.apache.org/jira/browse/KNOX-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870747#comment-15870747
]
Sandeep More commented on KNOX-869:
-----------------------------------
The patch looks great ! following are some minor suggestions
1. PreAuthService
1.1 getValidator(filterConfig) can be getValidators(filterConfig) in
keeping with the naming used in the rest of the patch.
1.2 Any reason why we are using LinkedHashSet and not HashSet ?
basically is order important here ?
2. PreAuthServiceTest
2.1 in testMultipleValidatorsNegative() method 'request' is not used
> Support multiple preauth Validators
> -----------------------------------
>
> Key: KNOX-869
> URL: https://issues.apache.org/jira/browse/KNOX-869
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
> Fix For: 0.12.0
>
> Attachments: KNOX-869.1.patch
>
>
> Currently KNOX-861 supports one validator. This task is to support a chain of
> validators.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
