[ 
https://issues.apache.org/jira/browse/KNOX-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885963#comment-15885963
 ] 

Sumit Gupta commented on KNOX-719:
----------------------------------

Thanks for the update [~jeffreyr97]! The patch looks much better and I tested 
it against a HA setup and it seems to work well. Just a couple of last nitpicks 
before I can push in the code:

1. There is an extraneous class RMUIHaHttpClientDispatch. Can this be removed?
2. There should be an opportunity to share some code between the various HA 
dispatches. There is a a lot of duplicate code that generally makes me 
uncomfortable.
3. There is an extra executeRequest method in the new Dispatch classes that is 
commented as a test method. Is this needed? I'm also uncomfortable with test 
only methods in code.

> Knox support for Yarn Resource Manager HA
> -----------------------------------------
>
>                 Key: KNOX-719
>                 URL: https://issues.apache.org/jira/browse/KNOX-719
>             Project: Apache Knox
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0, 0.8.0, 0.9.0, 0.10.0, 0.11.0
>            Reporter: Jeffrey E  Rodriguez
>            Assignee: Jeffrey E  Rodriguez
>             Fix For: 0.12.0
>
>         Attachments: KNOX-719-3.patch
>
>
> This would support both REST/UI YARN Resource Manager HA. Based on other HA 
> providers added in Knox.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to