[
https://issues.apache.org/jira/browse/KNOX-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated KNOX-958:
-------------------------------------
Description:
The gateway-tests module contains a GatewayTestConfig + a
GatewayFuncTestDriver, which more or less duplicate the classes available in
"gateway-test-release-utils".
See attached for a patch which does the following:
a) Move the functionality in GatewayFuncTestDriver which is only used by the
"basic" test into the test-class itself.
b) Remove GatewayFuncTestDriver + GatewayTestConfig from gateway-tests, and
instead pick up the classes from gateway-tests-release-utils.
c) Removed some duplicate dependencies from gateway-test-release-utils pom
I think for 1.0.0 we could remove the gateway-test-release-utils module
altogether, and move the two classes into gateway-test-utils, but for 0.13.0
it's probably better to leave them as is.
was:
The gateway-tests module contains a GatewayTestConfig + a
GatewayFuncTestDriver, which more or less duplicate the classes available in
"gateway-test-release".
See attached for a patch which does the following:
a) Move the functionality in GatewayFuncTestDriver which is only used by the
"basic" test into the test-class itself.
b) Remove GatewayFuncTestDriver + GatewayTestConfig from gateway-tests, and
instead pick up the classes from gateway-tests-release-utils.
c) Removed some duplicate dependencies from gateway-test-release-utils pom
I think for 1.0.0 we could remove the gateway-test-release-utils module
altogether, and move the two classes into gateway-test-utils, but for 0.13.0
it's probably better to leave them as is.
> Consolidate test config/drivers
> -------------------------------
>
> Key: KNOX-958
> URL: https://issues.apache.org/jira/browse/KNOX-958
> Project: Apache Knox
> Issue Type: Test
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Priority: Minor
> Fix For: 0.13.0
>
> Attachments: 0001-KNOX-958-Consolidate-test-config-drivers.patch
>
>
> The gateway-tests module contains a GatewayTestConfig + a
> GatewayFuncTestDriver, which more or less duplicate the classes available in
> "gateway-test-release-utils".
> See attached for a patch which does the following:
> a) Move the functionality in GatewayFuncTestDriver which is only used by the
> "basic" test into the test-class itself.
> b) Remove GatewayFuncTestDriver + GatewayTestConfig from gateway-tests, and
> instead pick up the classes from gateway-tests-release-utils.
> c) Removed some duplicate dependencies from gateway-test-release-utils pom
> I think for 1.0.0 we could remove the gateway-test-release-utils module
> altogether, and move the two classes into gateway-test-utils, but for 0.13.0
> it's probably better to leave them as is.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
