[ 
https://issues.apache.org/jira/browse/KNOX-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035013#comment-16035013
 ] 

Sandeep More commented on KNOX-954:
-----------------------------------

[~coheigea] The patch looks good, I am thinking for the 'ParseException' 
wouldn't it be good idea to log the error ? so know exactly what failed looking 
at the Knox logs.

> Don't consume parsing errors for JWT tokens
> -------------------------------------------
>
>                 Key: KNOX-954
>                 URL: https://issues.apache.org/jira/browse/KNOX-954
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 0.13.0
>
>         Attachments: 
> 0001-KNOX-954-Don-t-consume-parsing-errors-for-JWT-tokens.patch
>
>
> Right now, the JWTToken consumes an error on parsing a token. This is a bit 
> dubious and leads to NPEs in the filters (for example when trying to extract 
> claims). Adding back in the previously commented out test in 
> AbstractJWTFilterTest as part of this patch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to