[ 
https://issues.apache.org/jira/browse/KNOX-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064393#comment-16064393
 ] 

Jesus Alvarez edited comment on KNOX-776 at 6/27/17 7:20 AM:
-------------------------------------------------------------

Hey Sandeep,

Thanks for the feedback! I Made the suggested changes in the KNOX-776-2.patch 
attached.

I also moved the test case over to the existing WebsocketEchoTest, since it 
just needs a simple test for the new route path "<route 
path="/\*\*/channels\*\*"> and this seemed like a fairly light approach


was (Author: jesus.alv):
Hey Sandeep,

Thanks for the feedback! I Made the suggested changes in the KNOX-776-2.patch 
attached.

I also moved the test case over to the existing WebsocketEchoTest, since it 
just needs a simple test for the new route path "<route path="/**/channels**"> 
and this seemed like a fairly light approach

> Rewrite rule handling for Websockets
> ------------------------------------
>
>                 Key: KNOX-776
>                 URL: https://issues.apache.org/jira/browse/KNOX-776
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>            Reporter: Sandeep More
>            Assignee: Jesus Alvarez
>             Fix For: 0.13.0
>
>         Attachments: KNOX-776-2.patch, KNOX-776.patch
>
>
> Currently we simply proxy websocket payload we should support some form of 
> rewrite rule handling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to