[ 
https://issues.apache.org/jira/browse/KNOX-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129169#comment-16129169
 ] 

Sandeep More edited comment on KNOX-989 at 8/16/17 6:03 PM:
------------------------------------------------------------

Hello [~kamrul], 
Thanks for the patch, it looks good. While I was testing it out I saw that the 
InstrumentedGatewayFilter works as expected (with prefix - "client."), however 
there is another "service." requests that are not getting handled in the 
similar fashion see [^Screen Shot 2017-08-16 at 1.56.16 PM.png]. I am not sure 
where they are coming from, my initial reaction is that is is coming from 
InstrHttpClientBuilderProvider.  


was (Author: smore):
Hello [~kamrul], 
Thanks for the patch, it looks good. While I was testing it out I saw that the 
InstrumentedGatewayFilter works as expected (with prefix - "client."), however 
there is another "service." requests that are not getting handled in the 
similar fashion. I am not sure where they are coming from, my initial reaction 
is that is is coming from InstrHttpClientBuilderProvider.  

> Revisit JMX Metrics to fix the Out of Memory issue
> --------------------------------------------------
>
>                 Key: KNOX-989
>                 URL: https://issues.apache.org/jira/browse/KNOX-989
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>            Reporter: Sandeep More
>            Assignee: Mohammad Kamrul Islam
>             Fix For: 0.14.0
>
>         Attachments: KNOX-989.1.patch, Screen Shot 2017-08-16 at 1.56.16 
> PM.png
>
>
> Bug  [KNOX-986|https://issues.apache.org/jira/browse/KNOX-986] uncovers 
> problem with Metrics when large number of unique URLs are accessed via Knox. 
> The problem here is that Knox creates metrics objects per unique URL, the 
> metrics objects are not flushed out (for obvious reason - to maintain the 
> metric state). 
> We need to come up with a proper fix to mitigate this while being able to use 
> the JMX Metrics. 
> One way of doing this would be to have Metrics objects at service level ( 
> e.g. /gateway/sandbox/webhdfs/* ) the other way would be to have a reaper 
> process that clears out the unused objects. Other suggestions are welcomed !



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to