OK understood, I'll follow that from now on. Colm.
On Wed, Aug 30, 2017 at 5:39 PM, larry mccay <[email protected]> wrote: > Yes, I would say that JIRAs need to be filed for just about anything with > a description as to why the change is needed as well as for history. > There are a couple things that I will do without a JIRA - like updating > the CHANGES file while spinning out a release, things like that. > Sometimes, if a follow up change is needed for an existing JIRA - I will > just reuse the same JIRA number in the commit message. > > On Wed, Aug 30, 2017 at 12:32 PM, Colm O hEigeartaigh <[email protected] > > wrote: > >> Hi Sandeep, >> >> The commits only impacted on test code, and not any source code, and the >> changes were quite trivial so I didn't bother creating JIRAs. I'm happy to >> do so though for these scenarios if you'd like - do you want me to create >> JIRAs for the last 2 commits? >> >> Colm. >> >> On Wed, Aug 30, 2017 at 5:19 PM, Sandeep More <[email protected]> >> wrote: >> >> > Hello Colm, >> > >> > Do you have JIRA for this one ? (or probably I missed it) >> > As a best practice all commits have a JIRA attached to them so we can >> track >> > them back in future. >> > >> > Best, >> > Sandeep >> > >> > On Wed, Aug 30, 2017 at 12:00 PM, <[email protected]> wrote: >> > >> > > Repository: knox >> > > Updated Branches: >> > > refs/heads/master 6657f2fd9 -> 841295208 >> > > >> > > >> > > Removing some unused dependencies from gateway-test-release-utils >> > > >> > > >> > > Project: http://git-wip-us.apache.org/repos/asf/knox/repo >> > > Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/d5c2255f >> > > Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/d5c2255f >> > > Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/d5c2255f >> > > >> > > Branch: refs/heads/master >> > > Commit: d5c2255faac8fb1ef4d15cb53ca32056de1700ee >> > > Parents: 6657f2f >> > > Author: Colm O hEigeartaigh <[email protected]> >> > > Authored: Wed Aug 30 16:00:23 2017 +0100 >> > > Committer: Colm O hEigeartaigh <[email protected]> >> > > Committed: Wed Aug 30 16:00:23 2017 +0100 >> > > >> > > ------------------------------------------------------------ >> ---------- >> > > gateway-test-release-utils/pom.xml | 37 >> ------------------------------ >> > --- >> > > 1 file changed, 37 deletions(-) >> > > ------------------------------------------------------------ >> ---------- >> > > >> > > >> > > http://git-wip-us.apache.org/repos/asf/knox/blob/d5c2255f/ >> > > gateway-test-release-utils/pom.xml >> > > ------------------------------------------------------------ >> ---------- >> > > diff --git a/gateway-test-release-utils/pom.xml >> > > b/gateway-test-release-utils/pom.xml >> > > index b9a9081..b011e81 100644 >> > > --- a/gateway-test-release-utils/pom.xml >> > > +++ b/gateway-test-release-utils/pom.xml >> > > @@ -61,43 +61,12 @@ >> > > <artifactId>hamcrest-library</artifactId> >> > > <scope>provided</scope> >> > > </dependency> >> > > - <dependency> >> > > - <groupId>org.xmlmatchers</groupId> >> > > - <artifactId>xml-matchers</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > - <dependency> >> > > - <groupId>uk.co.datumedge</groupId> >> > > - <artifactId>hamcrest-json</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > >> > > <dependency> >> > > <groupId>org.slf4j</groupId> >> > > <artifactId>slf4j-api</artifactId> >> > > <scope>provided</scope> >> > > </dependency> >> > > - <dependency> >> > > - <groupId>log4j</groupId> >> > > - <artifactId>log4j</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > - >> > > - <dependency> >> > > - <groupId>org.eclipse.jetty</groupId> >> > > - <artifactId>jetty-server</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > - <dependency> >> > > - <groupId>org.eclipse.jetty</groupId> >> > > - <artifactId>jetty-servlet</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > - <dependency> >> > > - <groupId>org.apache.httpcomponents</groupId> >> > > - <artifactId>httpclient</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > >> > > <dependency> >> > > <groupId>com.mycila.xmltool</groupId> >> > > @@ -129,11 +98,5 @@ >> > > <scope>provided</scope> >> > > </dependency> >> > > >> > > - <dependency> >> > > - <groupId>org.apache.velocity</groupId> >> > > - <artifactId>velocity</artifactId> >> > > - <scope>provided</scope> >> > > - </dependency> >> > > - >> > > </dependencies> >> > > </project> >> > > \ No newline at end of file >> > > >> > > >> > >> >> >> >> -- >> Colm O hEigeartaigh >> >> Talend Community Coder >> http://coders.talend.com >> > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
