[ 
https://issues.apache.org/jira/browse/KNOX-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150686#comment-16150686
 ] 

Sandeep More edited comment on KNOX-953 at 9/1/17 3:08 PM:
-----------------------------------------------------------

Great thanks [~kamrul] !
Couple of things.
* Is the health.xml topology required (like knoxsso.xml) or can you simply 
include the <service> HEALTH </service> in your existing topology ? I think it 
would be nice if we explicitly point it out. 
* Looks like the example of the health.xml topology is incomplete (or ends 
abruptly) 
{code} 
+
+    <service>
+        <role>HEALTH</role>
+```
+
{code}

* We should also point out that to enable metrics we need to enable the two 
variables in gateway-site.xml viz.
**  gateway.metrics.enabled
**  gateway.jmx.metricsporting.enabled

Thanks again, for detailed examples in the documentation :)


was (Author: smore):
Great thanks [~kamrul] !
Couple of things.
* Is the health.xml topology required (like knoxsso.xml) or can you simply 
include the <service> HEALTH </service> in your existing topology ? I think it 
would be nice if we explicitly point it out. 
* Looks like the example of the health.xml topology is incomplete (or ends 
abruptly) 
{code} 
+
+    <service>
+        <role>HEALTH</role>
+```
+
{code}

* We should also point out that to enable metrics we need to enable the two 
variables in gateway-site.xml viz.
**  gateway.metrics.enabled
**  gateway.jmx.metricsporting.enabled


> Document KNOX health metrics REST API
> -------------------------------------
>
>                 Key: KNOX-953
>                 URL: https://issues.apache.org/jira/browse/KNOX-953
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Mohammad Kamrul Islam
>             Fix For: 0.14.0
>
>         Attachments: KNOX-953.1.patch, KNOX-953.2.patch
>
>
> The work is in progress to add REST API for KNOX health metrics including 
> heart beat type of features.
> This is to add documentations for that feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to