[ 
https://issues.apache.org/jira/browse/KNOX-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173366#comment-16173366
 ] 

Phil Zampino edited comment on KNOX-1041 at 9/20/17 3:47 PM:
-------------------------------------------------------------

This is interesting to me, due to the things I've recently been thinking about 
doing in Knox.

In BaseZookeeperURLManager.java, I think the class comment has a typo ("common 
delimited list"); I'm assuming you meant "comma-delimited list".

constructURL(String) comment incldues "http://host:post/solr";; Should that be 
"port" instead of "post"?

Also, could the synchronization be more granular? Many methods are 
synchronized, which locks the whole object.  Some methods, like 
setActiveURL(String) don't need any synchronization (unless there is an 
intention to replace the UnsupportedOperationException in the future).



was (Author: pzampino):
In BaseZookeeperURLManager.java, I think the class comment has a typo ("common 
delimited list"); I'm assuming you meant "comma-delimited list".

constructURL(String) comment incldues "http://host:post/solr";; Should that be 
"port" instead of "post"?

Also, could the synchronization be more granular? Many methods are 
synchronized, which locks the whole object.  Some methods, like 
setActiveURL(String) don't need any synchronization (unless there is an 
intention to replace the UnsupportedOperationException in the future).


> High Availability Support For Apache SOLR, HBase & Kafka
> --------------------------------------------------------
>
>                 Key: KNOX-1041
>                 URL: https://issues.apache.org/jira/browse/KNOX-1041
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: Server
>    Affects Versions: 0.12.0, 0.13.0
>            Reporter: Rick Kellogg
>            Assignee: Rick Kellogg
>             Fix For: 0.14.0
>
>         Attachments: KNOX-1041.patch
>
>
> Provide high-availability/fail-over between Knox and SOLR/HBase/Kafka using 
> the existing DefaultHaDispatch mechanism and a customized URLManager 
> implementation with knowledge of active hosts in Zookeeper.
> When SOLR Cloud is used the active hosts are stored in Zookeeper under the 
> /live_nodes path.  The attached custom URLManager implementation queries 
> Zookeeper for the active hosts upon startup.  In the event of fail-over, it 
> updates the internal list of hosts.
> The HS2ZookeeperURLManager implementation used to provide similar 
> functionality for Hive was used as a starting point.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to