[jira] [Commented] (KNOX-1055) Spark page characters "&" should be treated as a delimiter

[Sandeep More (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KNOX-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174117#comment-16174117
 ] 

Sandeep More commented on KNOX-1055:
------------------------------------

Thanks [~MarsChan] this is good find, can you submit a patch for this, also a 
unit test for this use case would be awesome ! 
And can you point out a specific url that causes the issue, it would be helpful 
in testing.

> Spark page characters "&" should be treated as a delimiter
> --------------------------------------------------------------
>
>                 Key: KNOX-1055
>                 URL: https://issues.apache.org/jira/browse/KNOX-1055
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 0.13.0
>            Reporter: Mars
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 0.14.0
>
>
> I am a beginner of apache knox. When I use knox to proxy my sparkhistoryui, I 
> meet this problem.
> {noformat} <a 
> href="/history/application_1505879554093_0036/stages/stage?id=0&amp;attempt=0"
>  class="name-link">{noformat}
> Some query parameters in the response body of the spark history ui contain a 
> {noformat}&amp;{noformat}.
> org.apache.hadoop.gateway.util.urltemplate.Parser#consumeQueryToken does not 
> handle this case
> {code:java}
> StringTokenizer tokenizer = new StringTokenizer( token, "?&" );
>       while( tokenizer.hasMoreTokens() ) {
>         consumeQuerySegment( builder, tokenizer.nextToken() );
>       }
> {code}
> so,I changed the code block as bellows
> {code:java}
> String[] tokens = token.split("(&amp;|\\?|&)");
>       if (tokens != null){
>         for (String nextToken : tokens){
>           consumeQuerySegment(builder,nextToken);
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)