[
https://issues.apache.org/jira/browse/KNOX-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated KNOX-1073:
--------------------------------------
Status: Patch Available (was: Open)
Please review the initial patch. It is tested successfully against an OIDC IdP.
Upgrades:
a) Pac4J -> 2.1.0
b) J2e Pac4J -> 3.0.0
c) Nimbus -> 4.34.2 (the same version used by Pac4J 2.1.0)
Issues with patch:
a) The Pac4jProviderTest is temporarily disabled. It is failing on line 148:
assertNull(userProfileCookie.getValue());
b) The configuration parameter Pac4jConstants.CLIENT_NAME (clientName) is
replaced by Pac4jConstants.CLIENTS. I decided to leave the configuration
parameter as "clientName" though for backwards compatibility.
c) In Pac4jIdentityAdapter, now returns Optional for "manager.get(true);". I
put the subsequent code in an "isPresent()" if statement, not entirely sure if
this is correct though.
d) The KnoxSessionStore has some additional methods that may need to be
overridden.
> Upgrade PAC4J to a more recent version
> --------------------------------------
>
> Key: KNOX-1073
> URL: https://issues.apache.org/jira/browse/KNOX-1073
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Fix For: 0.14.0
>
>
> This task is to upgrade PAC4J to a more recent version.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
