[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Zampino updated KNOX-1064:
-------------------------------
Attachment: KNOX-1064-004.patch
[~smore]
Attached KNOX-1064-004.patch, which includes responses to your review,
including:
* (3.1) Removed serviceConfiguration Map from AmbariServiceDiscovery
* (3.4) Removed comment from AmbariServiceDiscovery
* (4.1) Replaced all * imports with explicit imports in all modified files
* (4.2) Wrapped FileWriter in a BufferedWriter in SimpleDescriptorHandler
* (4.3) Moved the closing of the FileWriter to a finally block in
SimpleDescriptorHandler
* (5.n) Added a finally block to close the InputStream in
ServiceURLPropertyConfig
> Externalize Hadoop Service Configuration Details and Service URL Creation
> -------------------------------------------------------------------------
>
> Key: KNOX-1064
> URL: https://issues.apache.org/jira/browse/KNOX-1064
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.14.0
> Reporter: Phil Zampino
> Assignee: Phil Zampino
> Labels: kip-8
> Attachments: KNOX-1064-001.patch, KNOX-1064-002.patch,
> KNOX-1064-003.patch, KNOX-1064-004.patch, KNOX-1064.patch
>
>
> For the sake of flexibility in terms of the services supported by service
> discovery and topology generation, the following should be externalized from
> the code:
> # The set and mapping of service components and their respective
> configuration details.
> # The service URL generation details.
> The goal is to be able to add/modify these details without having to modify
> source code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
