Unfortunately, I found a blocker. I inadvertently committed a test service definition for AMBARIUI that I was using to test the simplified rewrite rules that the default service path element for topologies was supposed to enable.
Since I versioned the service definition as newer than the actual one it is the default definition and breaks existing Ambari proxying. Good news is that I tested the versioning capabilities by specifying the version attribute in the topology and it picked up the correct one and work. Bad news is my: -1 We may also want to take advantage of this and get new patches in that will round our the service discovery story. KNOX-1107 contains a patch for itself and KNOX-1010 - I will test this out and if it works propose that we include it in 0.14.0. Either way, I believe that this is a blocker and we should cancel the VOTE. On Wed, Nov 15, 2017 at 11:49 AM, Philip Zampino <[email protected]> wrote: > This version hash issue seems to be a local build-from-src problem for me; > the binary works as expected. > > Therefore, I vote +1 (non-binding) for this release. > > > > On Tue, Nov 14, 2017 at 9:57 PM, Philip Zampino <[email protected]> > wrote: > > > * Downloaded and built from source (with Java 1.8.0_144-b01) > > * Ran Knox tests > > * Manually tested service discovery and topology generation from simple > > descriptors > > * Manually tested the admin API > > > > I did encounter an issue with the Admin API; specifically, the server > > version API: > > > > /gateway/admin/api/v1/version yields an unexpected result. > > Instead of the server version hash, the response has "${buildNumber}" > > > > XML Response: > > <?xml version="1.0" encoding="UTF-8"?> > > <ServerVersion> > > <version>0.14.0</version> > > <hash>${buildNumber}</hash> > > </ServerVersion> > > > > JSON Response: > > { > > "ServerVersion" : { > > "version" : "0.14.0", > > "hash" : "${buildNumber}" > > } > > > > I built a couple of different ways, and the result is the same. > > It looks like the build.properties isn't being updated, and I'm not sure > > how/where that happens. > > > > > > > > > > On Fri, Nov 10, 2017 at 12:56 AM, larry mccay <[email protected]> wrote: > > > >> All - > >> > >> A candidate for the Apache Knox 0.14.0 release is available at: > >> > >> https://dist.apache.org/repos/dist/dev/knox/knox-0.14.0/ > >> > >> The release candidate is a zip archive of the sources in: > >> > >> https://git-wip-us.apache.org/repos/asf/knox.git > >> Branch v0.14.0 (git checkout -b v0.14.0) > >> > >> The KEYS file for signature validation is available at: > >> https://dist.apache.org/repos/dist/release/knox/KEYS > >> > >> Please vote on releasing this package as Apache Knox 0.14.0. > >> The vote is open for the next 72 hours and passes if a majority of at > >> least three +1 Apache Knox PMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Knox 0.14.0 > >> [ ] -1 Do not release this package because... > >> > >> thanks, > >> > >> --larry > >> > > > > >
