[
https://issues.apache.org/jira/browse/KNOX-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308768#comment-16308768
]
Rick Kellogg commented on KNOX-1156:
------------------------------------
My suggestion would be to simply throw away the disabled providers during
parsing. Then all the checks for enabled could be removed downstream. All
this requires substantial Q&A though. Agreed we should leave this alone for
1.0.0 though.
A few pieces of dodgy code:
* Within the ServiceDeploymentContributorBase.getProviderByRole, there should
probably be a check for enabled as well.
* Within Topology.getProvider if name is not specified we could look for
enabled items.
* DeploymentFactory.collectTopologyProviders, use of contains on
ProviderDeploymentContributor which does not implement hashCode or equals.
* Similar issue in DeploymentFactory.selectContextServices with hashCode and
equals.
> Disabled / Multiple Providers Yield Broken Deployment
> -----------------------------------------------------
>
> Key: KNOX-1156
> URL: https://issues.apache.org/jira/browse/KNOX-1156
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.10.0, 0.11.0, 0.12.0, 0.13.0, 0.14.0
> Reporter: Rick Kellogg
> Assignee: Rick Kellogg
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: KNOX-1056.patch
>
>
> Within the topology XML file, the providers include an enabled element. If
> you include multiple providers with the same role the generated gateway.xml
> file might not include the enabled providers.
> In my specific example, I had two authentication providers. The first of
> which was disabled and the second was enabled. The second provider was
> ignored yielding no authentication provider in the gateway.xml and then
> subsequent use of the identity provider failed with a missing Subject.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
