[
https://issues.apache.org/jira/browse/KNOX-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508225#comment-16508225
]
Marco Gaido commented on KNOX-1160:
-----------------------------------
[~lmccay] This patch breaks versions less than 2.4.
In particular, we can distinguish 2 cases:
- Spark versions before SPARK-23644 (ie. <= 2.3.0): this is the case [~weihan]
tried to address. He tried to fix SPARK-23644 using Knox rewrite rules and he
wrote Knox rewrite rules because he didn't set {{spark.ui.proxyBase}}. The
problem is that the rules fixing SPARK-23644 are causing other problems, ie.
they are breaking the logs link. The point is that SPARK-23644 happens if the
path used to access SHS doesn't end with a "/". So a user who has now Knox +
SHS (and set {{spark.ui.proxyBase}} as it should be done for Spark < 2.4) and
is accessing it using "/" at the end of its path will see a regression. In all
other cases we will anyway have some broken links (namely the log links).
- Spark versions after SPARK-23644 (ie. 2.3.1 +): this patch breaks all the
links in the JS, so both the applications links and the log links, in any case.
So I hope that I made clear that even though the issues introduced by this
patch are much worse in Spark 2.3.1 +, the patch is introducing regressions
also for Spark <= 2.3.0. So we cannot fix by using versions. The best solution
here in my opinion is reverting this patch and I'd suggest to [~weihan] to use
{{spark.ui.proxyBase}} and to put a "/" at the end of the URL (or backporting
SPARK-23644 to his Spark version) in order to fix his issues.
> Bug fixes to make spark history UI work
> ---------------------------------------
>
> Key: KNOX-1160
> URL: https://issues.apache.org/jira/browse/KNOX-1160
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Wei Han
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: sparkhistoryui.patch
>
>
> During my test of the spark history UI I found a couple of issues. The
> attached patch fixes all of the issues I have seen
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
