[ 
https://issues.apache.org/jira/browse/KNOX-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624326#comment-16624326
 ] 

Larry McCay commented on KNOX-1442:
-----------------------------------

[~risdenk] - thanks for this patch as well.

I'm glad that these are separated too - just in case one needs to be reverted.

The thing about such large patches with sort of minor fixes, is that they can 
make backports really difficult.

I can see the forbidden apis themselves but replacing explicit imports with 
wildcard imports probably shouldn't be done.

Personally, I don't care for wildcard imports even though they seem to be en 
vogue again for certain things.

I assume that these changes are also not part of the forbidden apis report?

Can we discard those import changes?

Of course there may end up being unused imports as a result that would need to 
be removed.

 

> Enable forbiddenapis for static build checking
> ----------------------------------------------
>
>                 Key: KNOX-1442
>                 URL: https://issues.apache.org/jira/browse/KNOX-1442
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.2.0
>
>         Attachments: KNOX-1442.patch
>
>
> Split out from KNOX-1284 specifically for forbiddenapis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to