[ 
https://issues.apache.org/jira/browse/KNOX-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625135#comment-16625135
 ] 

Kevin Risden edited comment on KNOX-1443 at 9/23/18 3:02 PM:
-------------------------------------------------------------

Some rules to enforce:
 * Check that ASF header matches correctly for java files
 * Ensure no unused imports
 * Ensure no wildcard imports
 * No tabs in source files


was (Author: risdenk):
Some rules to start with:
 * Check that ASF header matches correctly for java files
 * Ensure no unused imports
 * Ensure no wildcard imports

> Add checkstyle to enforce coding style
> --------------------------------------
>
>                 Key: KNOX-1443
>                 URL: https://issues.apache.org/jira/browse/KNOX-1443
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.2.0
>
>
> Checkstyle (http://checkstyle.sourceforge.net/) is a tool to enforce coding 
> standards. Checkstyle can be enabled as a Maven plugin to ensure that the 
> build fails if there are style violations.
> One coding standard that came out of KNOX-1441 and KNOX-1442 review is no 
> wildcard imports. There may be others but that is at least a starting point.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to