I believe so. Thanks for creating the Jira ! Best, Sandeep
On Sun, Sep 23, 2018 at 1:36 PM Kevin Risden <[email protected]> wrote: > Along the same lines, there are two test classes (KnoxLdapRealmTest and > KnoxPamRealmTest) in the gateway-adapter module that look to be exactly the > same as other tests. Are these two classes to make sure the backwards > compatibility still works or were they supposed to be removed? > > Kevin Risden > > > On Sun, Sep 23, 2018 at 1:26 PM Kevin Risden <[email protected]> wrote: > > > Created https://issues.apache.org/jira/browse/KNOX-1445 to look into > this. > > > > Kevin Risden > > > > > > On Sun, Sep 23, 2018 at 1:24 PM Sandeep Moré <[email protected]> > > wrote: > > > >> Most likely this is because these classes were added after the > >> refactoring, > >> but yes they all should have @Deprecated tag. > >> > >> On Sun, Sep 23, 2018 at 1:19 PM > >> Kevin Risden > >> <[email protected]> wrote: > >> > >> > As far as I understand, the gateway-adapter module was created to move > >> from > >> > org.apache.hadoop.gateway.* to org.apache.knox.gateway.* class names. > >> > > >> > While looking at some of the code, there are multiple classes in the > >> > gateway-adapter module that don't have @Deprecated annotations. I > think > >> > that all the classes should have @Deprecated because they extend the > new > >> > org.apache.knox.gateway.* classes. > >> > > >> > Any reason that @Deprecated is missing from some classes in the > >> > gateway-adapter module? > >> > > >> > Some examples: > >> > * DefaultDispatch > >> > * NiFiDispatch > >> > * NiFiHaDispatch > >> > * PassAllHeadersDispatch > >> > * PassAllHeadersNoEncodingDispatch > >> > ... > >> > > >> > Kevin Risden > >> > > >> > > >
