[
https://issues.apache.org/jira/browse/KNOX-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628760#comment-16628760
]
Kevin Risden commented on KNOX-1455:
------------------------------------
So there are a few things this patch does that apache-rat doesn't seem to care
about:
* Standardize on one header
** Remove dangling javadoc (/** to /*) at start of header
** Remove <p> or <p/> from header since not a javadoc
** Ensure same spacing is used for all headers (some of the headers are
narrower)
* Ensure the header starts at the top of the file
** I'm surprised apache-rat doesn't care about this. There are 37 files where
the header is after the package and even imports.
> Enable checkstyle ASF header check rule
> ---------------------------------------
>
> Key: KNOX-1455
> URL: https://issues.apache.org/jira/browse/KNOX-1455
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.2.0
>
> Attachments: KNOX-1455.patch
>
>
> {code:java}
> <!-- Checks for headers -->
> <!-- See http://checkstyle.sf.net/config_header.html -->
> <!-- Verify that EVERY source file has the appropriate license -->
> <module name="Header">
> <property name="headerFile" value="${checkstyle.header.file}"/>
> </module>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
