[
https://issues.apache.org/jira/browse/KNOX-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639852#comment-16639852
]
Kevin Risden commented on KNOX-1433:
------------------------------------
The only concern I have with this patch is SafeModeException is thrown when
"body.contains("RetriableException")". I have never seen a RetriableException
in YARN especially not in the YARN RM UI.
I checked the Hadoop source code for SafeModeException being thrown and only
HDFS classes throw it. RetriableException is used by YARN to retry and then
fail. I don't see it being displayed anywhere that Knox would pick it up.
> RMHaBaseDispatcher Class Cleanup - SafeModeException
> ----------------------------------------------------
>
> Key: KNOX-1433
> URL: https://issues.apache.org/jira/browse/KNOX-1433
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Matthew Sharp
> Assignee: Kevin Risden
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: KNOX-1433.patch
>
>
> The RMHaBaseDispatcher appears to have been based heavily off HDFS HA
> dispatch and has a couple areas that can be cleaned up.
> # SafeModeException - will never be thrown for RM
> # retryRequest() - not used anywhere else outside SafeModeException
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
