smolnar82 commented on a change in pull request #55: KNOX-1162 - Logging
stacktrace for FATAL messages and displaying a meaningful error message in case
of missing/non-parsable JAAS configuration
URL: https://github.com/apache/knox/pull/55#discussion_r258075247
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java
##########
@@ -34,13 +34,13 @@
public interface GatewayMessages {
@Message( level = MessageLevel.FATAL, text = "Failed to parse command line:
{0}" )
- void failedToParseCommandLine( @StackTrace( level = MessageLevel.DEBUG )
ParseException e );
+ void failedToParseCommandLine( @StackTrace( level = MessageLevel.FATAL )
ParseException e );
Review comment:
The JIRA requested that there should be no FATAL messages displayed on DEBUG
level (which I agree with); so I believe this is necessary. Any objection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
