risdenk commented on a change in pull request #54: [WIP] KNOX-1756 - Knox
Gateway TLS Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/54#discussion_r258103226
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java
##########
@@ -159,21 +159,36 @@ private void logAndValidateCertificate() throws
ServiceLifecycleException {
throw new ServiceLifecycleException("Gateway SSL Certificate is not
yet valid. Server will not start.", e);
}
} else {
- throw new ServiceLifecycleException("Public certificate for the
gateway cannot be found with the alias gateway-identity. Plase check the
identity certificate alias.");
+ throw new ServiceLifecycleException("Public certificate for the
gateway cannot be found. Please check the identity certificate alias.");
}
} else {
throw new ServiceLifecycleException("Public certificate for the gateway
is not of the expected type of X509Certificate. Something is wrong with the
gateway keystore.");
}
}
@Override
- public Object buildSslContextFactory(String keystoreFileName ) throws
KeyStoreException, IOException, CertificateException, NoSuchAlgorithmException {
+ public Object buildSslContextFactory(GatewayConfig gatewayConfig) throws
KeyStoreException, IOException, CertificateException, NoSuchAlgorithmException {
+ char[] master = ms.getMasterSecret();
Review comment:
move this to line 188?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
