smolnar82 commented on a change in pull request #56: KNOX-1756 - Knox Gateway
TLS Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r258818070
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java
##########
@@ -450,6 +481,22 @@ private void removeFromCache(String clusterName, String
alias) {
@Override
public String getKeystorePath() {
- return keyStoreDir + GATEWAY_KEYSTORE;
+ return config.getIdentityKeystorePath();
+ }
+
+ private char[] getIdentityKeystorePassword() throws KeystoreServiceException
{
Review comment:
`getIdentityKeystorePassword` and `getSigningKeystorePassword` has the same
implementation except for the password alias they are fetching the credential
for. What if you create a new private method `getKeystorePassword(String
passwordAlias)` and you invoke this one with the proper params
(`config.getIdentityKeystorePasswordAlias()` or
`config.getSigningKeystorePasswordAlias()`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
