rlevas commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS
Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r258986214
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -201,15 +211,11 @@ private void addDefaultConfig(String
clientNameParameter, Map<String, String> pr
catch(AliasServiceException ase) {
log.noPrivateKeyPasshraseProvisioned(ase);
}
- if (gip != null) {
- properties.put(PropertiesConfigFactory.SAML_PRIVATE_KEY_PASSWORD,
- new String(gip));
- }
- else {
+ if (gip == null) {
Review comment:
That would be outside the scope of this patch. But I would have loved to do
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
