risdenk edited a comment on issue #56: KNOX-1756 - Knox Gateway TLS Keystore 
and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#issuecomment-466525115
 
 
   > Would you like this behavior changed to require `--force` if the entry 
exists in the keystore? However I think overwriting was the behavior before the 
changes in this patch.
   
   I think the existing behavior made sense when it was in 
`data/security/keystores/gateway.jks`. This was a path that was fully owned by 
Knox. Since we are now following the path to the custom keystore, we should be 
more careful about what we overwrite. Not sure how easy it would be to check if 
the identity path is the default vs a configured one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to