rlevas commented on issue #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias 
Should be Configurable
URL: https://github.com/apache/knox/pull/56#issuecomment-466526178
 
 
   > The check in `DefaultKeystoreService` should be removed because it doesn't 
belong in the `KeystoreService`. The `KeystoreService` impl should be generic 
to what is stored in the keystore. Currently the signing certificate check 
breaks that design.
   
   Would you like this changed in this patch.  It seems like maybe it would 
fall under a different issue, but I will fix it here is desired. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to