risdenk commented on issue #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias 
Should be Configurable
URL: https://github.com/apache/knox/pull/56#issuecomment-466530869
 
 
   > I guess we can see if the path is the expected default and maybe also see 
if the cert is self-signed and has the DN of the Gateway-created one. If so, we 
blindly overwrite, else we require a `--force`. This seems like it may fall 
under a different issue, but I can fix it in this patch if desired.
   
   I think it should be fixed here since the check for self-signed was 
introduced in this patch. I worry that someone will have their own self signed 
certificate overridden by mistake if we introduce this patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to