[
https://issues.apache.org/jira/browse/KNOX-1791?focusedWorklogId=203738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203738
]
ASF GitHub Bot logged work on KNOX-1791:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/19 16:37
Start Date: 25/Feb/19 16:37
Worklog Time Spent: 10m
Work Description: rlevas commented on pull request #58: KNOX-1791 -
MasterService should be a field on GatewayServices
URL: https://github.com/apache/knox/pull/58
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
Currently "MasterService" is a string throughout the code base. This should
be a field on the interface GatewayServices like other services.
- Added `GatewayServices.MASTER_SERVICE` constant.
- Alphabetized service name constants in `GatewayServices`
- Replaced "MasterService" strings speckled throughout the code with
`GatewayServices.MASTER_SERVICE`
- Replaced an instance of "SSLService" with "GatewayServices.SSL_SERVICE"
## How was this patch tested?
(Please explain how this patch was tested. For instance: running automated
unit/integration tests, manual tests. Please write down your test steps as
detailed as possible)
(If this patch involves UI changes, please attach a screen-shot; otherwise,
remove this)
Please review [Knox Contributing
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 203738)
Time Spent: 10m
Remaining Estimate: 0h
> MasterService should be a field on GatewayServices
> --------------------------------------------------
>
> Key: KNOX-1791
> URL: https://issues.apache.org/jira/browse/KNOX-1791
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Robert Levas
> Priority: Trivial
> Fix For: 1.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently "MasterService" is a string throughout the code base. This should
> be a field on the interface GatewayServices like other services.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
