[
https://issues.apache.org/jira/browse/KNOX-1789?focusedWorklogId=203859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203859
]
ASF GitHub Bot logged work on KNOX-1789:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/19 19:35
Start Date: 25/Feb/19 19:35
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #59: KNOX-1789 -
Refactor RemoteAliasService to use service loading
URL: https://github.com/apache/knox/pull/59#discussion_r259984585
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/CLIGatewayServices.java
##########
@@ -70,16 +54,21 @@ public void init(GatewayConfig config, Map<String,String>
options) throws Servic
defaultAlias.setKeystoreService(ks);
defaultAlias.init(config, options);
+ final RemoteConfigurationRegistryClientService registryClientService =
+ RemoteConfigurationRegistryClientServiceFactory.newInstance(config);
+ registryClientService.setAliasService(defaultAlias);
Review comment:
Doesn't make sense for this to be set to the remote alias service since this
could be remote itself. This uses the default alias service in case of digest
authentication.
If digest auth and using remote alias service, then wouldn't be able to
connect to ZK anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 203859)
Time Spent: 20m (was: 10m)
> Refactor RemoteAliasService to use service loading
> --------------------------------------------------
>
> Key: KNOX-1789
> URL: https://issues.apache.org/jira/browse/KNOX-1789
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently RemoteAliasService is setup to only have a Zookeeper
> implementation. It would be better to make this generic with service loading
> and configuration. This would allow plugging in different Remote alias
> implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
