[
https://issues.apache.org/jira/browse/KNOX-1793?focusedWorklogId=205257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205257
]
ASF GitHub Bot logged work on KNOX-1793:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 17:40
Start Date: 27/Feb/19 17:40
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #61: KNOX-1793 -
DefaultKeystoreService should not validate the signing key on initialization
URL: https://github.com/apache/knox/pull/61#discussion_r260863833
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/DefaultGatewayServices.java
##########
@@ -51,6 +50,33 @@
private static GatewayMessages log = MessagesFactory.get(
GatewayMessages.class );
+ private static final String[] SERVICE_START_ORDER = new String[]{
Review comment:
Not sure if it is easy to reverse the array. Might be easier to do
`Arrays.asList(...)`. Your comment about reversing the list for stop makes
sense to me.
Side note - I've wanted to do this for a long time. Even on the init method.
Init is harder since there are dependencies but still seems like it should be
possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 205257)
Time Spent: 2h 50m (was: 2h 40m)
> DefaultKeystoreService should not validate the signing key on initialization
> ----------------------------------------------------------------------------
>
> Key: KNOX-1793
> URL: https://issues.apache.org/jira/browse/KNOX-1793
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Robert Levas
> Assignee: Robert Levas
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The {{org.apache.knox.gateway.services.security.impl.DefaultKeystoreService}}
> implementation should not validate the _signing_ key on initialization. This
> should be a validation task for users of the signing key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
